-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : 그룹 초대 받은 목록, 보낸 목록 API 추가 #465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 API 메서드명 통일성을 위해 변경 - 기존 API 쿼리에 where 절에 조건 없어서 추가 - 그룹 초대 보낸 목록 조회 API 추가
- 현재 그룹원 포함 최대 30명까지 초대 가능하므로 슬라이스 대신 리스트로 변경 - 패키지 이름 변경
- 같은 시간인 경우 오류가 발생해 loe -> lt로 변경
- 시간 기반 페이징의 로직 상 오류로 테스트 실패 - 아이디 기반 커서 페이징으로 변경해야 함
.../core/domain/member_group/repository/group_invite_repository/GroupInviteQueryRepository.java
Outdated
Show resolved
Hide resolved
GaBaljaintheroom
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 수고했엉 미리 승인해놀겡
…oup_invite_list-B-#458
- 더 명확한 의미를 위해 반의어인 receiving으로 수정
…st-B-#458 # Conflicts: # backend/core/src/main/java/site/timecapsulearchive/core/domain/member_group/api/query/MemberGroupQueryApi.java # backend/core/src/main/java/site/timecapsulearchive/core/domain/member_group/api/query/MemberGroupQueryApiController.java # backend/core/src/main/java/site/timecapsulearchive/core/domain/member_group/service/MemberGroupCommandService.java # backend/core/src/main/java/site/timecapsulearchive/core/domain/member_group/service/MemberGroupQueryService.java # backend/core/src/test/java/site/timecapsulearchive/core/domain/member_group/service/MemberGroupCommandServiceTest.java
- import 경로 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 (Content)
링크 (Links)
기타 사항 (Etc)
Merge 전 필요 작업 (Checklist before merge)
희망 리뷰 완료 일 (Expected due date)